Implementation of validator for active viewport - #167
Conversation
BigRoy
left a comment
BigRoy
left a comment
There was a problem hiding this comment.
Overall looks ok, just cosmetic notes.
…t.py Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
…ps://github.com/ynput/ayon-3dsmax into bugfix/165-Validate-Render-Active-Viewport-Used
BigRoy
left a comment
BigRoy
left a comment
There was a problem hiding this comment.
Lovely. Needs testing by @LiborBatek
…t.py Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
LiborBatek
left a comment
LiborBatek
left a comment
There was a problem hiding this comment.
The validator correctly kicks in but the Repair action does not work and didnt unset it (disabled the lock option)...
Leading to unability to pass the validation and publish....
Careless mistake. Should be fixed in d1cdfaf |
LiborBatek
left a comment
LiborBatek
left a comment
There was a problem hiding this comment.
Hmm, still I cannot pass the validator as the Repair does not affect that lock button and keep it active still.
Seems like the latest commit didnt help sry.
…ps://github.com/ynput/ayon-3dsmax into bugfix/165-Validate-Render-Active-Viewport-Used
The extra logic of updating the render dialog confuses 3dsmax in terms of setting up the toggle of the active viewport. |
4 participants
Changelog Description
This PR is to implement the validator to check whether the render setting is enabling the active viewport for rendering.
Fixes: #165
Additional review information
n/a
Testing notes: